[BioRuby] Bio::SPTR bug and fix

[Ben Woodcroft]

Thanks.

You are the first person to call me Dr. Ben Woodcroft - while I don't mind
the sound of that I'm still a first year PhD student.

ben

2008/9/30 Naohisa GOTO <ngoto at gen-info.osaka-u.ac.jp>

> Thank you.
>
> I modified your patch and committed to my repository.
>
>
> http://github.com/ngoto/bioruby/commit/6299d291b925442d828ff2a95c4526c45dc62208
>
> It will soon be merged to the main bioruby git repo.
>
> Naohisa Goto
> ngoto at gen-info.osaka-u.ac.jp / ng at bioruby.org
>
> On Tue, 30 Sep 2008 14:21:12 +1000
> "Ben Woodcroft" <donttrustben at gmail.com> wrote:
>
> > Hi,
> >
> > So I was trying to parse a uniprot file, and I found that bioruby threw
> an
> > error when asked it to return a DR key that didn't exist in the uniprot
> file
> > (in particular, GO annotations when none were defined).
> >
> > I made a branch that fixes this by returning [] in that situation, and
> added
> > a test for it as well:
> > http://github.com/wwood/bioruby/tree/sptr_fix
> >
> > If this code is good enough then can I request it be merged into the
> tree?
> >
> > Thanks,
> > ben
> >
> > --
> > FYI: My email addresses at unimelb, uq and gmail all redirect to the same
> > place.
> > _______________________________________________
> > BioRuby mailing list
> > BioRuby at lists.open-bio.org
> > http://lists.open-bio.org/mailman/listinfo/bioruby
>
> _______________________________________________
> BioRuby mailing list
> BioRuby at lists.open-bio.org
> http://lists.open-bio.org/mailman/listinfo/bioruby
>



-- 
FYI: My email addresses at unimelb, uq and gmail all redirect to the same
place.