[Biopython-dev] Code quality with Quantified code
Peter Cock
p.j.a.cock at googlemail.com
Thu Dec 3 17:17:01 UTC 2015
Interesting for me, but probably only a few of us on the biopython-dev
would be interested?
Can you turn on GitHub pull request tests though? That way in addition
to seeing the TravisCI test results, we'd get a warning about coding
style and issues flagged from the static analysis QuantifiedCode does.
Peter
On Thu, Dec 3, 2015 at 4:55 PM, Tiago Rodrigues Antao <tra at popgen.net> wrote:
> Hi,
>
> Whenever there is a commit, QuantifiedCode sends an email to the person
> setting up the repository on QC with the new problems. Would there be
> an interest to have this sent to this list directly?
>
> Here is what I received:
> https://www.quantifiedcode.com/app/project/554b34dfff644b75b9f647aeab1d6461/diff/a46eaf3d615d97f541a779901b4cb2e736afc12d/b23936d0f224d2c34256f68a69fb6172bd6e5824/issues
>
> On Thu, 3 Dec 2015 13:54:25 +0000
> Peter Cock <p.j.a.cock at googlemail.com> wrote:
>
>> On Thu, Dec 3, 2015 at 12:27 PM, Carlos Pena <mycalesis at gmail.com>
>> wrote:
>> > I can see the page and list of bugs without the need to log in. I am
>> > using Chrome in Linux.
>>
>> This seems to be an incompatibility with Apple Safari and the
>> Quantified Code website. Firefox seems to work for me :)
>>
>> https://www.quantifiedcode.com/app/project/554b34dfff644b75b9f647aeab1d6461
>>
>> And looking at the top fault, I have to agree this if statement in
>> bgzf.py needs looking at (I forget now why I wrote it this way):
>>
>> https://github.com/biopython/biopython/commit/7d4523d6bbd2fa59c798c40ced38f5976ce64fa9#diff-8f35ada1444d6f77e41c86b649ba88ecR539
>>
>> Peter
>
More information about the Biopython-dev
mailing list