[Biopython-dev] TogoWS in Biopython?

[Peter Cock]

On Wed, Nov 2, 2011 at 1:27 PM, Peter Cock <p.j.a.cock at googlemail.com> wrote:
> On Wed, Nov 2, 2011 at 12:19 PM, Brad Chapman <chapmanb at 50mail.com> wrote:
>>
>> Peter;
>>
>>> > Would someone like to review the TogoWS code I have written
>>> > to access the Togo Web Service's REST API please?
>>
>> This looks great and the tests are all passing for me. My only small
>> suggestion would be to avoid hardcoding 'http://togows.dbcls.jp'
>> everywhere. I'd stick this as a top level variable along with the global
>> caches and reference it in the code. This way if they ever get any
>> mirrors we could adjust on the fly.
>>
>> Thanks for getting this in,
>> Brad
>
> Good point regarding the URL.
>
> I've also realised it will need some tweaks for Python 3 (bytes
> versus unicode), or at least to skip the unit tests in the short
> term to avoid hiding real errors on the buildbot.
>
> Peter

That is on the trunk now, further testing and feedback welcome.
https://github.com/biopython/biopython/commit/a4875c62d44c40cebfc11d84654ad9dcb83c81b3

Peter