[Bioperl-l] EMBL file with space before quoted, multi-line qualifier value

Fields, Christopher J cjfields at illinois.edu
Fri Apr 10 16:27:03 UTC 2015


On Apr 10, 2015, at 3:35 AM, Adam Sjøgren <adsj at novozymes.com> wrote:
> 
> Christopher writes:
> 
>> As long as this passes current tests I don’t have a problem with
>> adding it in. I would suggest adding a simple test case for it; you
>> could modify a current EMBL file in the data directory if needed for a
>> test case, probably no need to add a new file.
> 
> None of the tests fail on my machine after adding the patch.
> 
> I have created a pull request, including a test, now:
> 
> * https://github.com/bioperl/bioperl-live/pull/111
> 
> It looked cleaner to me to add the simple embl test file, than to add a
> "bogus" feature to one of the existing files, but I can of course change
> that, if that is preferred.
> 
> 
>  Best regards,
> 
>    Adam

Works for me, thanks for the fix Adam!  I just merged the pull into master.

chris



More information about the Bioperl-l mailing list