[Biojava-dev] demo directories not being compiled

[Spencer Bliven]

A biojava-demo module is a good idea. That would also reduce the redundancy
between the structure and structure-gui demo classes (which generally just
differ in the visualization code). It would also be nice to have a module
that depends on all of biojava (to highlight dependency conflicts and to
improve the visioneye dependency graph). The only downside would be that
users might be confused which modules are needed for each demo, but this
could be easily fixed by using packages like org.biojava.demo.[module].

On Thu, Feb 5, 2015 at 8:24 PM, ALESSANDRO AIEZZA (RIT Student) <
axa9070 at rit.edu> wrote:

> Mark = Good Idea!
>
>
> On Thursday, February 5, 2015, Mark Fortner <phidias51 at gmail.com> wrote:
>
>> You could also build a separate JAR with demo apps.
>>
>> Cheers,
>>
>> Mark
>>
>>
>> On Thu, Feb 5, 2015 at 9:31 AM, Andreas Prlic <andreas at sdsc.edu> wrote:
>>
>>> Hi,
>>>
>>> I mostly excluded them since I did not want to have the demo package
>>> name in our release jars... Perhaps we can find a way so they get compiled,
>>> but not included in the packaging of the jars...
>>>
>>> A
>>>
>>> On Thu, Feb 5, 2015 at 3:18 AM, Spencer Bliven <sbliven at ucsd.edu> wrote:
>>>
>>>> I noticed that demo directories are now excluded from maven builds.
>>>> While it's true that these aren't needed in the final jar, we should still
>>>> make sure that they compile correctly.  For instance, there are currently
>>>> some missing imports in
>>>> biojava-structure-gui/...demo/DemoAlignmentFromFasta which were being
>>>> masked. The exclusion setting also prevents them from being considered
>>>> classes in Eclipse, meaning you can't run them, compile them, etc.
>>>>
>>>> I believe they were excluded from the build because of duplicated
>>>> classes between structure and structure-gui modules, as well as to keep the
>>>> package names consistent. However, maybe it would be better to rename them
>>>> to org.biojava.nbio.module.demo instead?
>>>>
>>>>
>>>> Eclipse workaround:
>>>>
>>>> Right-click 'src/main/java' > Build Path > Configure
>>>> Inclusion/exclusion filters. Delete the exclusion patterns.
>>>>
>>>>
>>>> -Spencer
>>>>
>>>> _______________________________________________
>>>> biojava-dev mailing list
>>>> biojava-dev at mailman.open-bio.org
>>>> http://mailman.open-bio.org/mailman/listinfo/biojava-dev
>>>>
>>>
>>>
>>>
>>>
>>> _______________________________________________
>>> biojava-dev mailing list
>>> biojava-dev at mailman.open-bio.org
>>> http://mailman.open-bio.org/mailman/listinfo/biojava-dev
>>>
>>
>>
> _______________________________________________
> biojava-dev mailing list
> biojava-dev at mailman.open-bio.org
> http://mailman.open-bio.org/mailman/listinfo/biojava-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.open-bio.org/pipermail/biojava-dev/attachments/20150206/f13abdfb/attachment.html>