[BioPython] Bug in BioSQL/Loader.py
Peter
biopython at maubp.freeserve.co.uk
Thu Nov 8 16:56:53 UTC 2007
Hilmar Lapp wrote:
> On Nov 8, 2007, at 9:21 AM, Eric Gibert wrote:
>
>> qualifier_value = qualifiers[qualifier_key][qual_value_rank]
>> sql = r"INSERT INTO seqfeature_qualifier_value VALUES" \
>> r" (%s, %s, %s, %s)"
>
> Not enumerating the columns in the INSERT clause is dangerous
> programming I think. This should be fixed, and should be fixed for
> all statements where it is an issue.
I agree with you 100% on this issue.
As I still haven't made the time to setup a BioSQL database on my
machine, I would be grateful if someone could check the patch on newly
filed Bug 2384,
http://bugzilla.open-bio.org/show_bug.cgi?id=2394
Thanks
Peter
More information about the Biopython
mailing list