[Biopython-dev] Interested in contributing (Issue #664)

[Peter Cock]

On Mon, Nov 23, 2015 at 8:49 AM, Vishnu Chilakamarri
<vishnuc11j93 at gmail.com> wrote:
> Hello,
>
> My name is Vishnu and I'm working as a developer with skills in Java and
> Python. I am keen to contribute to open source projects and know about
> Biopython since when I was in college although I haven't used it much.
>
> I was looking into issue #664 on github and went though the code. The issue
> is fixed but I have some doubts on this fix :
>
> 1. There is a change in regular expression that needs to be done in order to
> make it compatible to handle negative weights. Version 1.58 handles this is
> a different way, which is the preferred method?
>
> 2. The need for functional test cases was discussed in the page, should that
> be included too before I commit the code?
>
> Thanks in advance!

Hi Vishnu,

RE: https://github.com/biopython/biopython/issues/664

You can comment directly on #664 if you like, or make a pull request
with your proposed fix? Ideally also add the proposed test too.

Eric is probably the best person to comment on the code here.

Peter