[Biopython-dev] Landscape.io & GitHub Fwd: Pull Request Status and Faster Checks

[Peter Cock]

It looks like code quality checking and GitHub integration in general
is getting better all the time! Tiago setup landscape.io for us here:

https://landscape.io/github/biopython/biopython

Peter

---------- Forwarded message ----------
From: Carl from Landscape.io <carl at landscape.io>
Date: Fri, Dec 4, 2015 at 10:09 AM
Subject: Pull Request Status and Faster Checks
To: p.j.a.cock at googlemail.com



[image: Landscape] Landscape


Pull Request Status and Faster Checks

Landscape.io
<http://landscape.us4.list-manage.com/track/click?u=cb57338e2fd8f66c847376971&id=911885d342&e=efc72173f3>
is a tool for checking your Python code and pointing out errors, problems
and stylistic issues. Think of it like an automatic code review. You are
receiving this email because you signed up for updates about new features.
You can unsubscribe
<http://landscape.us4.list-manage1.com/unsubscribe?u=cb57338e2fd8f66c847376971&id=fb176c5620&e=efc72173f3&c=3f50edf87c>
to stop receiving these emails.

Two updates for you this time: improvements to both pull request
integration with GitHub, and checks are now up to five times quicker.
Previously, Landscape would create a comment on pull requests
<http://landscape.us4.list-manage.com/track/click?u=cb57338e2fd8f66c847376971&id=ea5f2ca3cf&e=efc72173f3>
showing the change in code quality introduced by the proposed code. This
was often quite spammy, though, and therefore pull request status is now
set using GitHub's status API.

This means that, when you create a pull request, you will see something
like this:



The default behaviour is simply to add information about the code check to
the pull request. If you like, you can have Landscape mark the pull request
as "failed" if code quality deteriorates - you can do this in your
preferences
<http://landscape.us4.list-manage.com/track/click?u=cb57338e2fd8f66c847376971&id=f48d5709d4&e=efc72173f3>
either for entire
organisations or on a per-repository basis.

Currently, failing can only be triggered by any decrease in score. If you
would like to have different criteria - for example, fail due to new errors
only but don't worry about smells - please file an issue on the issue
tracker
<http://landscape.us4.list-manage.com/track/click?u=cb57338e2fd8f66c847376971&id=2c78db99ea&e=efc72173f3>
or
drop me an email
<carl at landscape.io?subject=Pull%20Request%20Status%20Criteria> so I can
figure out what kind of behaviour is useful!

The old commenting system is still available but has been disabled by
default in favour of the status updates. You can however enable it in your
preferences
<http://landscape.us4.list-manage.com/track/click?u=cb57338e2fd8f66c847376971&id=7a731955b2&e=efc72173f3>.
It can still sometimes be useful if you tend to make pull requests then add
more commits afterwards, as with the status-api, it only represents the
most recent commit of the PR branch. The bot comments allow you to see how
new commits compare to old commits, if that history is useful to you.

This fixes issues #108
<http://landscape.us4.list-manage.com/track/click?u=cb57338e2fd8f66c847376971&id=c7c0dde271&e=efc72173f3>
, #158
<http://landscape.us4.list-manage2.com/track/click?u=cb57338e2fd8f66c847376971&id=74bf13626b&e=efc72173f3>and
#160
<http://landscape.us4.list-manage.com/track/click?u=cb57338e2fd8f66c847376971&id=5519a20a21&e=efc72173f3>
.

*Faster Checks*

The slowest part of the checks for some time has been setting up a virtual
environment and installing the various requirements of projects. This is
necessary to help with inferring types and APIs used by project code -
without the complete requirements, there are often several incorrect or
spurious warnings.

These requirements are now cached between checks. The first check will
still be slow as the environment is buit for the first time, but afterwards
the requirements installation is a lot faster, and will only need to fetch
and install libraries if the versions depended on have changed.



Terms
<http://landscape.us4.list-manage1.com/track/click?u=cb57338e2fd8f66c847376971&id=be7595bcdb&e=efc72173f3>
| Privacy
<http://landscape.us4.list-manage1.com/track/click?u=cb57338e2fd8f66c847376971&id=e0a14c659a&e=efc72173f3>
| Unsubscribe
<http://landscape.us4.list-manage1.com/unsubscribe?u=cb57338e2fd8f66c847376971&id=fb176c5620&e=efc72173f3&c=3f50edf87c>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.open-bio.org/pipermail/biopython-dev/attachments/20151204/44159997/attachment-0001.html>