[Biopython-dev] Bio.Entrez batch download example with retries

Peter Cock p.j.a.cock at googlemail.com
Mon Dec 1 10:06:14 UTC 2014


On Mon, Dec 1, 2014 at 2:04 AM, Vincent Davis <vincent at vincentdavis.net> wrote:
> I submitted a pull request, let me know if this is what you had in mind.
>
> Vincent Davis

Thanks Vincent,

Yes, that's what I was hoping for :)

I made some comments on https://github.com/biopython/biopython/pull/436

Can you look at those and update the pull request? The simplest way is
make a second commit on your branch, and push the updated branch to
github which will automatically update the pull request.

As an aside, since you are working on that example, we ought to make it
more PEP8 compliant - note the white space changes from:

     for start in range(0,count,batch_size):
        end = min(count, start+batch_size)
        print("Going to download record %i to %i" % (start+1, end))

to:

     for start in range(0, count, batch_size):
        end = min(count, start + batch_size)
        print("Going to download record %i to %i" % (start + 1, end))

There are probably quite a few bits like that still in the Tutorial, but this
is not urgent.

Thanks,

Peter


More information about the Biopython-dev mailing list