[Biopython-dev] Fwd: [biopython] Custom GenBank locus length (#171)

[Marco Galardini]

Good afternoon everyone,

Actually, i have been testing a bit more and some other changes may be 
needed (sorry about that, this is my first change to the biopython code).
The assertions on the lines length still fail, so my guess is that 
probably it's not a good idea to try to write down a genbank with 
unusual identifiers (even if they are from JGI!).

Marco

On 03/28/2013 04:44 PM, Peter Cock wrote:
> For those not getting the pull request emails from GitHub,
>
> ---------- Forwarded message ----------
> From: Marco Galardini <notifications at github.com>
> Date: Thu, Mar 28, 2013 at 3:19 PM
> Subject: [biopython] Custom GenBank locus length (#171)
> To: biopython/biopython <biopython at noreply.github.com>
>
>
> Instead of an exception, raise a warning, so the file is saved and the
> user can decide to correct the error.
>
> I don't know if this is a good pratice, but I have some GenBank files
> provided by the JGI/DOE with locus names longer than 16 chars, so I
> guess that providing a warning to the user instead of a complete
> failure could be better.
>
> ________________________________
>
> You can merge this Pull Request by running
>
>    git pull https://github.com/mgalardini/biopython patch-1
>
> Or view, comment on, or merge it at:
>
>    https://github.com/biopython/biopython/pull/171
>
> Commit Summary
>
> Custom GenBank locus length
>
> File Changes
>
> M Bio/SeqIO/InsdcIO.py (4)
>
> Patch Links:
>
> https://github.com/biopython/biopython/pull/171.patch
> https://github.com/biopython/biopython/pull/171.diff
> _______________________________________________
> Biopython-dev mailing list
> Biopython-dev at lists.open-bio.org
> http://lists.open-bio.org/mailman/listinfo/biopython-dev


-- 
-------------------------------------------------
Marco Galardini, PhD
Dipartimento di Biologia
Via Madonna del Piano, 6 - 50019 Sesto Fiorentino (FI)

e-mail: marco.galardini at unifi.it
www: http://www.unifi.it/dblage/CMpro-v-p-51.html
phone:  +39 055 4574737
mobile: +39 340 2808041
-------------------------------------------------