[Biopython-dev] Moratorium on commits?
Peter Cock
p.j.a.cock at googlemail.com
Mon Aug 12 20:40:24 UTC 2013
On Monday, August 12, 2013, Morten Kjeldgaard wrote:
>
> On 11/08/2013, at 22:50, Peter Cock <p.j.a.cock at googlemail.com<javascript:;>>
> wrote:
>
> > I still feel this was a minor change (although of
> > course important to some, including you). This is
> > parsing of malformed PDF files where the user
> > ALREADY gets a warning (or error in strict mode,
> > where there would be no functional change) that
> > there is a problem with the occupancy data.
> >
> > One reason why I specifically talked about small
> > commits (in the sense of a simple diff) above is
> > they are trivial to revert if the need arises, or as
> > in this case, modify:
> >
> https://github.com/biopython/biopython/commit/500c3c2ea900fd8c8f5123f571d4d9a244ee898e
> >
> > This change was suggested and supported by
> > people who've been actively contributing to the
> > Biopython structural module for some time, so I
> > had reason to trust their good judgement, and as
> > I wrote at the time there was a clear consensus
> > with three people in all happy with the idea:
> >
> http://lists.open-bio.org/pipermail/biopython-dev/2013-August/010773.html
>
>
> I respect that you listen more to developers that
have been contributing for a long time. That is quite
understandable, but I hope that does not prevent
me from contributing my opinions.
Of course not - your input (which was after the initial
change) has already resulted in a review of that
change and the adoption of None instead.
So thank you for speaking up,
Peter
More information about the Biopython-dev
mailing list