[Biopython-dev] New functions in Bio.PDB: renumber_residues(), remove_disordered_atoms()

[Eric Talevich]

Hi João,

Now that Biopython 1.57 is out, I'd like to try merging some more features
into the trunk. I'm looking at this branch:
https://github.com/JoaoRodrigues/biopython/commits/pdb_enhancements

Can I pull and merge the whole branch, or should I cherry-pick certain
commits? And, have you already squashed the history to your own
satisfaction?

Thanks,
Eric


On Thu, Feb 17, 2011 at 7:59 AM, João Rodrigues <anaryin at gmail.com> wrote:

> Hey Kristian,
>
> To Tests/test_pdb.py ? Just to make sure that the renumbering acts on both
> accordingly? I agree.
>
> João
>
>
On Thu, Feb 17, 2011 at 7:54 AM, Kristian Rother <krother at rubor.de> wrote:

>
> Hi Joao,
>
> I think we should add a simple test function that ensures consistency of
> child_dict and child_list upon renumbering. Let me know if you'd prefer me
> to explain in Python what I mean.
>
> Kristian
>
>
>
> > Dear All,
> >
> > I've been working on the above-mentioned functions following really great
> > feedback from Eric, Kristian, and Peter. I've been also using them
> > routinely
> > and I've had no problems yet so they should be stable enough. Therefore I
> > think they can be cherry-picked from my pdb_enhancements branch and added
> > to
> > the main branch. Let me know what you think.
> >
> > Cheers,
> >
> > João
> >
> > _______________________________________________
>