[Biopython-dev] [Bug 3096] PPBuilder build_peptides bugs

[bugzilla-daemon at portal.open-bio.org]

http://bugzilla.open-bio.org/show_bug.cgi?id=3096





------- Comment #6 from skong at zymeworks.com  2010-09-09 13:42 EST -------
Hi Peter,

I tested out the code (on the script directly, not using git) and it works
fine. I only have minor concerns that the additional input variable
"standard_aa_only" for _accept() method in class _PPBuilder might break other
codes that assumes it still has two instead of three input variables. 

Also within the same script there are three different naming and default value
for the same flag (standard amino acid):

1. named "standard" with default False in is_aa() method
2. named "aa_only" with default 1 in build_peptides() method of class
_PPBuilder
3. named "standard_aa_only" with no default value in _accept() method of class
_PPBuilder

Which is again minor. 


-- 
Configure bugmail: http://bugzilla.open-bio.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.