[Biopython-dev] Bio/cMarkovModelmodule.c

[Michiel de Hoon]

OK, done. In the end, I put the warning message in MarkovModel.py anyway, since it's very easy to miss if it's in setup.py.

--Michiel.

--- On Sat, 10/30/10, Peter <biopython at maubp.freeserve.co.uk> wrote:

> From: Peter <biopython at maubp.freeserve.co.uk>
> Subject: Re: [Biopython-dev] Bio/cMarkovModelmodule.c
> To: "Michiel de Hoon" <mjldehoon at yahoo.com>
> Cc: biopython-dev at biopython.org
> Date: Saturday, October 30, 2010, 8:43 AM
> On Sat, Oct 30, 2010 at 12:39 PM,
> Michiel de Hoon wrote:
> > Currently there is a pure-Python fall back for _logadd
> in
> > MarkovModel.py. We could check if the numpy version
> > is at least 1.3 in setup.py, show a warning if an
> older
> > numpy is found, and use the fall back in
> MarkovModel.py
> > if numpy does not contain logaddexp. Then if we
> remove
> > cMarkovModelmodule.c, in the worst case (a Windows
> > user with Python 2.4 who cannot update to a more
> recent
> > Python) MarkovModel.py will be a bit slower, but no
> > functionality is lost.
> >
> > --Michiel.
> 
> That sounds OK to me :)
> 
> Once we drop Python 2.4 maybe we can also list
> NumPy 1.3 as the minimum supported NumPy?
> 
> Peter
>