[Biopython-dev] [Bug 2949] _parse_pdb_header_list: REVDAT is for oldest entry.

[bugzilla-daemon at portal.open-bio.org]

http://bugzilla.open-bio.org/show_bug.cgi?id=2949





------- Comment #3 from eric.talevich at gmail.com  2010-03-21 23:50 EST -------
(In reply to comment #2)
> So, the actual code is showing the oldest date from REVDAT. I don't know if you
> (the developer) are trying to say with 'release_date' if is the first version
> or the last. But I think, as Paul said, that should be the most current date.

It's probably an accidental result of repeatedly setting the same field. Surely
the most recent revision date is at least as important as the date of the first
revision, given that the initial deposition date is recorded separately.

I'm not the original developer, but I'd say it would be best to keep a list or
dictionary in a new "revisions" attribute, leaving release_date alone or
deprecating it in case someone is actually relying on the current behavior.

We should discuss this on biopython-dev before implementing it.

> Other thing, instead to add 'mod_number', 'mod_id', 'mod_type' directly into
> dict. I think that these keys should be inside a 'release_data' key:

That name could lead to some typo-related confusion... but yes, a list-of-dicts
or dict-of-dicts would be a nice way to store this info.


-- 
Configure bugmail: http://bugzilla.open-bio.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.