[Biopython-dev] [Bug 3105] Bio.Nexus useless line

bugzilla-daemon at portal.open-bio.org bugzilla-daemon at portal.open-bio.org
Mon Jul 5 10:31:39 UTC 2010


http://bugzilla.open-bio.org/show_bug.cgi?id=3105





------- Comment #6 from biopython-bugzilla at maubp.freeserve.co.uk  2010-07-05 06:31 EST -------
(In reply to comment #4)
> It's a typo (a rather old one). 
> 
> Type checking has been changed to isinstance.
> 
> Frank

I've just changed it back to method checking, i.e. as Eric suggested with
my typo fixed:

if hasattr(filename, 'write'):

The trouble with isinstance(filename, file) is that it doesn't allow for file
like objects - specifically a StringIO handle as used in the unit tests,
meaning test_AlignIO.py was failing.

Peter


-- 
Configure bugmail: http://bugzilla.open-bio.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the Biopython-dev mailing list