[Biopython-dev] [Bug 3118] isinstance should use basestring for detecting string type

[bugzilla-daemon at portal.open-bio.org]

http://bugzilla.open-bio.org/show_bug.cgi?id=3118





------- Comment #2 from biopython-bugzilla at maubp.freeserve.co.uk  2010-07-17 18:30 EST -------
Hi Claude,

Some of those should really be str (e.g. for the SeqFeature extract test
in SeqFeatureExtractionWritingReading if the input is a str then the output
should be too; also for BioSQL some of the adaptors do care about string vs
unicode so that needs more checking), but in general you have a good point.

In this particular case, yes - thank you:
http://github.com/biopython/biopython/commit/450b1a9024490feb2cdbbbc30f1dc429620d8c41

I think we need some more unit tests here (especially for BioSQL), which
will help with the current Python 3 testing via 2to3, where string vs
unicode is a big issue.

Leaving bug open...

Peter


-- 
Configure bugmail: http://bugzilla.open-bio.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.