[Biopython-dev] [Bug 3045] TreeMixin, please define enumerator and other convenience methods

[bugzilla-daemon at portal.open-bio.org]

http://bugzilla.open-bio.org/show_bug.cgi?id=3045





------- Comment #1 from biopython-bugzilla at maubp.freeserve.co.uk  2010-04-06 18:25 EST -------
Interesting. I don't really see the need for most of these given how routine
use of the enumerate function is elsewhere in Python. So -1 on the enumerate
methods.

I'm not fond of the name of the existing method get_terminals (which currently
returns a list). My feeling is that using just terminals seems nicer (as a
property, so no order argument - if you need that use the find method). Is
there any advantage to returning a list vs an iterator? Everything is all in
memory anyway, right?

Given a terminals property (be it a read only list or an iterator), one might
go further and add a sister property for the internal nodes (non-terminal
nodes).

What are your thoughts Eric?

Peter


-- 
Configure bugmail: http://bugzilla.open-bio.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.