[Biopython-dev] [Bug 2759] Unit test for Bio.PDB.HSExposure

[Eric Talevich]

On Sat, Mar 21, 2009 at 12:14 PM, Giovanni Marco Dall'Olio <
dalloliogm at gmail.com> wrote:

> On Sat, Mar 21, 2009 at 4:23 PM, Eric Talevich <eric.talevich at gmail.com>
> wrote:
> > On Sat, Mar 21, 2009 at 10:32 AM, <bugzilla-daemon at portal.open-bio.org
> >wrote:
> >
> >> http://bugzilla.open-bio.org/show_bug.cgi?id=2759
> >>
> >>
> >> ok... Is your branch this one:
> >> -
> >>
> http://github.com/etal/biopython/commit/65f5cf9fa8d6d63976b0942e00bd9aecef7e4197
> >> ?
> >>
> >>
> >> This was my proposal:
> >> -
> >>
> http://github.com/dalloliogm/biopython/blob/alternative-pdb-exposure-test/Tests/test_PDBexposure.py
> >>
>
>
> If you want to use it, the problem is that it make use of a decorator
> function (@classmethod) which is not supported by earlier versions of
> python.
>
>
Decorators and @classmethod were added in Python 2.4. Since support for
Python 2.3 is being dropped after the release of BioPython 1.50 (I believe),
it should be safe to apply the decorator to post-1.50 branches. If this
needs to be in 1.50, the older way of "mymethod = classmethod(mymethod)"
would work fine in Py2.3, although I personally would just move the PDB
loading steps to setUp, since the parser is pretty quick and the code for
that is easy to read.

I'll finish up my work on Bug 2754 and merge/rebase it before trying to
integrate this code -- that should bring the parse warnings under control
and make it easier for Peter to dispatch this bug.