[Biopython-dev] [Bug 2759] Unit test for Bio.PDB.HSExposure

[bugzilla-daemon at portal.open-bio.org]

http://bugzilla.open-bio.org/show_bug.cgi?id=2759





------- Comment #2 from dalloliogm at gmail.com  2009-02-12 08:36 EST -------
(In reply to comment #1)
> Created an attachment (id=1234)
 --> (http://bugzilla.open-bio.org/attachment.cgi?id=1234&action=view) [details]
> New unit test for Bio.PDB.HSExposure
> 
> This does not cover the DSSP or residue depth calculation, as these require 3rd
> party tools (DSSP and MSMS) to be installed.
> 

Can I suggest you a small refactoring of the test unit?
I would move all the asserts in setUp to different functions.

Then, it would be good to put also the call to PDB.PDBStructure to a global
fixture, to avoid to repeat it for every test.

Moreover, I will generalize all the know values and put them as variables, so
later you will be able to apply the same test to other files by just
subclassing the test.

Let me know what is your opinion... :)


-- 
Configure bugmail: http://bugzilla.open-bio.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.