[Biopython-dev] [Bug 2629] Updated Bio.NaiveBayes to listfns import

bugzilla-daemon at portal.open-bio.org bugzilla-daemon at portal.open-bio.org
Mon Nov 3 19:33:39 UTC 2008


http://bugzilla.open-bio.org/show_bug.cgi?id=2629





------- Comment #4 from bsouthey at gmail.com  2008-11-03 14:33 EST -------
(In reply to comment #3)
> I committed part of this patch to CVS; see NaiveBayes.py revision 1.9.
> Could you check your classify function? It seems to contain some debugging
> statements. Also, do we need the classifyprob function?
> If you send in a new version of this code, please attach it as a patch to the
> current version of NaiveBayes.py in CVS.
> Thanks!
> 

Yes, there is a print statement at the end of the 'classify' function (line 125
of attached file) that should be removed (as with any print statements that are
commented out). These were to check that the values were the same as the
original code. 

The classifyprob function can be dropped with not problems. I just wanted to
return the probability but I also recognize that it is not very useful.


I noticed you are using set (line 145 in the new cvs file) which is not
compatible with Python2.3. How should this be addressed?


-- 
Configure bugmail: http://bugzilla.open-bio.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the Biopython-dev mailing list