[Biopython-dev] [Bug 2671] Including GenomeDiagram in the main Biopython distribution

[bugzilla-daemon at portal.open-bio.org]

http://bugzilla.open-bio.org/show_bug.cgi?id=2671





------- Comment #31 from biopython-bugzilla at maubp.freeserve.co.uk  2008-12-18 14:01 EST -------
(In reply to comment #27)
> This might be better off as a new enhancement bug, but here is a possible
> "arc-box" drawing function to go in the AbstractDrawer.py file, based on the
> existing draw_box function.
> 
> ...

There was an issue with different frames of reference in the initial code I was
suggesting.

> Alternately, the code could just go in CircularDrawer.py directly.

This seemed simpler in the short term.

> As far as I can tell from looking at their source code, even ReportLab_1_21_2
> has ArcPath defined in reportlab.graphics.shapes so there shouldn't be any
> issue here with backwards compatibility.

I've just checked in a patch based on this - see
Bio/Graphics/GenomeDiagram/CircularDrawer.py revision 1.8

I've also updated the unit test to draw a circular diagram with some features
in white (with an automatic black border).  This now looks nice - with the old
code using mutliple boxes to fake the arced box, the whole feature ended up
looking black.  See Tests/test_GenomeDiagram.py revision 1.13

As a bonus, PDF output seems a little smaller now as well :)


-- 
Configure bugmail: http://bugzilla.open-bio.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.