[Biopython-dev] [Bug 2711] GenomeDiagram.py: write() and write_to_string() are inefficient and don't check inputs

[bugzilla-daemon at portal.open-bio.org]

http://bugzilla.open-bio.org/show_bug.cgi?id=2711





------- Comment #10 from biopython-bugzilla at maubp.freeserve.co.uk  2008-12-15 06:00 EST -------
(In reply to comment #8)
> 
> > 4) I do not know the policy on module imports, but this line is only
> > required for write() and write_to_string():
> > from reportlab.graphics import renderPS, renderPDF, renderSVG, renderPM
> > Also renderPM is an addon.
> 
> Apologies for repeating myself earlier about this one - Bugzilla was being
> flaky - but renderPM is now part of ReportLab 2.2.  Whether we should continue
> to support/cater for installations of 1.21 without the add-ons is another
> question, I think.

I thought I'd commented on this bug already but I committed a patch which would
fail gracefully if renderPM was missing.  I must be running an older version of
ReportLab on my Linux box at home, because it didn't have renderPM installed.  

However - this check is done when writing the file.  This is good if you don't
have renderPM but only want vector images.  This is bad if you do want bitmaps
images, as the missing dependency error happens at the very end.

However, I don't think we can assume renderPM will be installed.  Looking at
the website for reportlab 2.2, its not clear if the Windows installers will
include renderPM or not...


-- 
Configure bugmail: http://bugzilla.open-bio.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.