[Biopython-dev] [Bug 2697] MaxEntropy calculate function assumes integer values for class and convergence criteria is hard coded

[bugzilla-daemon at portal.open-bio.org]

http://bugzilla.open-bio.org/show_bug.cgi?id=2697





------- Comment #4 from mdehoon at ims.u-tokyo.ac.jp  2008-12-13 23:27 EST -------
(In reply to comment #3)
> I strongly disagree on this because a user should not have to read the module
> source code to find these module level global variables and what values these
> actually are. But this is not my code.
> 
I agree with Bruce that these variables should be arguments to the function,
rather than module-level global variables. To keep the API backwards
compatible, we can specify the current values for these variables as default
values for these arguments. This will also make it easier for users that are
not particularly interested in these variables.

If you submit a revised patch, please do not just comment out unneeded code; it
is better to actually remove code that is no longer needed.


-- 
Configure bugmail: http://bugzilla.open-bio.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.