[Biopython-dev] [Bug 2671] Including GenomeDiagram in the main Biopython distribution

[bugzilla-daemon at portal.open-bio.org]

http://bugzilla.open-bio.org/show_bug.cgi?id=2671


biopython-bugzilla at maubp.freeserve.co.uk changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
Attachment #1063 is|0                           |1
           obsolete|                            |
Attachment #1121 is|0                           |1
           obsolete|                            |




------- Comment #15 from biopython-bugzilla at maubp.freeserve.co.uk  2008-12-01 11:59 EST -------
Created an attachment (id=1132)
 --> (http://bugzilla.open-bio.org/attachment.cgi?id=1132&action=view)
Zip of python files to go under Bio/Graphics/GenomeDiagram

This attachment is just the main python files, omitting DrawAll.py and
Utilities.py (see comment 12 and comment 14).  The unit test needs updating to
match (but then passes, updated version to follow).

(In reply to comment #0)
> Code for wx widgets has been removed, although the Observer/Observable code
> remains, allowing user widgets to hook into the code, if that's desirable.

There was a tiny bit of wx stuff still there in Diagram.py which I have removed
in this version.

After discussion with Leighton directly, due to possible uncertainly over the
licensing of the Observer/Observable code (originally based on an example by
Peter Norvig) this has been removed, together with the associated "set" methods
in Diagram.py etc.  This code was intended to assist using GenomeDiagram within
a GUI.

Note that if we later want to reintroduce this functionality, using python's
property feature (with get/set functions) would allow the set function to
update the observer.  Leighton's old code would only update the observer if the
set method was used explicitly (and not if the object property were updated
directly).

(In reply to comment #6)
> I am perfectly happy with re-licensing the GD code under the Biopython
> license. If you need a gpg-signed document to say so, I can provide one ;)

I've updated the header of each file to reflect the Biopython license.


-- 
Configure bugmail: http://bugzilla.open-bio.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.