[Biopython-dev] [Bug 2481] bitscore not parsed.

[bugzilla-daemon at portal.open-bio.org]

http://bugzilla.open-bio.org/show_bug.cgi?id=2481


mdehoon at ims.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |biopython-
                   |                            |bugzilla at maubp.freeserve.co.
                   |                            |uk




------- Comment #5 from mdehoon at ims.u-tokyo.ac.jp  2008-04-05 06:03 EST -------
OK, I see.


Three more comments though:

1) In NCBIXML.py:
method = self._secure_name('_end_' + name.replace("-","_"))
I don't see why name.replace("-","_") is needed. Isn't that the purpose of
self._secure_name in the first place?

2) In Record.py:
Please add "bits" with a description to the docstring (lines 58-65).

3) About your change:
> Lines 409-410 uncommented
I wonder why these lines were commented out in the first place. It was done in
revision 1.8 of NCBIXML.py, but I didn't see any explanation as to why those
lines were commented out. Peter, do you know?


-- 
Configure bugmail: http://bugzilla.open-bio.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.