[Biopython-dev] [Bug 2230] New: GenBank __init__.py: _Scanner import

[bugzilla-daemon at portal.open-bio.org]

http://bugzilla.open-bio.org/show_bug.cgi?id=2230

           Summary: GenBank __init__.py: _Scanner import
           Product: Biopython
           Version: Not Applicable
          Platform: Macintosh
        OS/Version: Mac OS
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Main Distribution
        AssignedTo: biopython-dev at biopython.org
        ReportedBy: mcolosimo at mitre.org


This is bad coding IMHO and took me several minutes to figure out where the
class was.

from Scanner import GenBankScanner as _Scanner

since this is used only two times and referenced once!

Index: __init__.py
===================================================================
RCS file: /home/repository/biopython/biopython/Bio/GenBank/__init__.py,v
retrieving revision 1.67
diff -r1.67 __init__.py
25c25
< _Scanner              Set up a GenBank parser to parse a record.
---
> GenBankScanner              Set up a GenBank parser to parse a record.
47c47
< from Scanner import GenBankScanner as _Scanner
---
> from Scanner import GenBankScanner
178c178
<         self._scanner = _Scanner(debug_level)
---
>         self._scanner = GenBankScanner(debug_level)
202c202
<         self._scanner = _Scanner(debug_level)
---
>         self._scanner = GenBankScanner(debug_level)


-- 
Configure bugmail: http://bugzilla.open-bio.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.