[Biopython-dev] Notification: incoming/81

[biopython-bugs at bioperl.org]

JitterBug notification

new message incoming/81

Message summary for PR#81
	From: Jeffrey Chang <jchang at smi.stanford.edu>
	Subject: Re: [Biopython-dev] Notification: incoming/80
	Date: Tue, 6 Aug 2002 10:42:33 -0700
	0 replies 	0 followups

====> ORIGINAL MESSAGE FOLLOWS <====

>From jchang at springfield.stanford.edu Tue Aug  6 13:46:04 2002
Received: from springfield.stanford.edu (springfield.Stanford.EDU [128.12.147.41])
	by pw600a.bioperl.org (8.12.2/8.12.2) with ESMTP id g76Hk3JD028568
	for <biopython-bugs at bioperl.org>; Tue, 6 Aug 2002 13:46:04 -0400
Received: (from jchang at localhost)
	by springfield.stanford.edu (8.11.6/8.11.6) id g76HgXJ01902;
	Tue, 6 Aug 2002 10:42:33 -0700 (PDT)
	(envelope-from jchang)
Date: Tue, 6 Aug 2002 10:42:33 -0700
From: Jeffrey Chang <jchang at smi.stanford.edu>
To: daishi at egcrc.net
Cc: biopython-bugs at bioperl.org
Subject: Re: [Biopython-dev] Notification: incoming/80
Message-ID: <20020806104233.B1810 at springfield.stanford.edu>
Mail-Followup-To: daishi at egcrc.net, biopython-bugs at bioperl.org
References: <200208060038.g760cOJD019975 at pw600a.bioperl.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5.1i
In-Reply-To: <200208060038.g760cOJD019975 at pw600a.bioperl.org>; from biopython-bugs at bioperl.org on Mon, Aug 05, 2002 at 08:38:24PM -0400

Hi Daishi,

Thanks for the report and patch.  I am at ISMB right now.  I will look
at this when I get back home at the end of this week.

Jeff


On Mon, Aug 05, 2002 at 08:38:24PM -0400, biopython-bugs at bioperl.org wrote:
> JitterBug notification
> 
> new message incoming/80
> 
> Message summary for PR#80
> 	From: daishi at egcrc.net
> 	Subject: Bio.File.SGMLHandle tail condition error
> 	Date: Mon, 5 Aug 2002 20:38:23 -0400
> 	0 replies 	0 followups
> 
> ====> ORIGINAL MESSAGE FOLLOWS <====
> 
> >From daishi at egcrc.net Mon Aug  5 20:38:23 2002
> Received: from localhost (localhost [127.0.0.1])
> 	by pw600a.bioperl.org (8.12.2/8.12.2) with ESMTP id g760cNJD019971
> 	for <biopython-bugs at pw600a.bioperl.org>; Mon, 5 Aug 2002 20:38:23 -0400
> Date: Mon, 5 Aug 2002 20:38:23 -0400
> Message-Id: <200208060038.g760cNJD019971 at pw600a.bioperl.org>
> From: daishi at egcrc.net
> To: biopython-bugs at bioperl.org
> Subject: Bio.File.SGMLHandle tail condition error
> 
> Full_Name: daishi
> Module: Bio.File.SGMLHandle
> Version: CVS 1.13
> OS: Linux
> Submission from: 63-193-205-1.egcrc.org (63.193.205.1)
> 
> 
> Starting at L154 of File.py is the code:
> 
>         if self._parser.data:
>             str = self._parser.data
>         elif is_newline:
>             str = '\n'
>         return str
> 
> There needs to be a final else clause to
> catch the circumstance when the file ends
> with a tag but no newline. As it is currently,
> such a tag will be returned by SGMLStripper
> since str would not be redefined.
> 
> Since this can only occur at the end of a file,
> I believe this can just be changed to:
> 
>         if self._parser.data:
>             str = self._parser.data
>         elif is_newline:
>             str = '\n'
>         else:
>             str = ''
>         return str
> 
> 
> 
> 
> _______________________________________________
> Biopython-dev mailing list
> Biopython-dev at biopython.org
> http://biopython.org/mailman/listinfo/biopython-dev