[Biopython-dev] Martel

[Cayte]

   My impression of Martel is that it will require extensive testing, because it has so many paths.  The tests cover the basic expressions, but I'd be surprised if there are no weird interactions.  The code may lose its context, on complicated paths.  I could help with adding unit tests.

  In a few cases, I think the names need to be more descriptive.  Variables like p, s or av don't give a lot of information.  Also, the name "pattern" is used for too many things, that have different meanings.  The regular expression is sometimes "source" and sometimes "s".  At least, I, need all the help I can get, navigating the recursion.:)!  An example of a construct that confused me is:

    x = sre_parse.parse(s, pattern = MultigroupPattern())
    return convert_list(x.pattern, x)


  Finding self-documenting names can be hard, but sometimes the effort to find the right metaphor clarifies your thinking.

                                                       Cayte
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://portal.open-bio.org/pipermail/biopython-dev/attachments/20000916/ecb91433/attachment.htm