<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On 9 April 2015 at 16:18, Fields, Christopher J <span dir="ltr"><<a href="mailto:cjfields@illinois.edu" target="_blank">cjfields@illinois.edu</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Apr 9, 2015, at 8:03 AM, Adam Sjøgren <<a href="mailto:adsj@novozymes.com">adsj@novozymes.com</a>> wrote:<br>
><br>
> Adam writes:<br>
><br>
>> - my( $qualifier, $value ) = m{^/([^=]+)(?:=(.+))?}<br>
>> + my( $qualifier, $value ) = m{^/([^=]+)*(?:=\s*(.+))?}<br>
> |<br>
> I got a '*' to many there -----------------------'<br>
><br>
> I (only) meant to add the '\s*' after the '=':<br>
><br>
> + my( $qualifier, $value ) = m{^/([^=]+)(?:=\s*(.+))?}<br>
><br>
> Sorry!<br>
><br>
> --<br>
> Adam Sjøgren<br>
> <a href="mailto:adsj@novozymes.com">adsj@novozymes.com</a><br>
<br>
</span>As long as this passes current tests I don’t have a problem with adding it in. I would suggest adding a simple test case for it; you could modify a current EMBL file in the data directory if needed for a test case, probably no need to add a new file.<br>
<br>
I’ve long felt there's a fine line between having a parser being a strict validation tool and having it be flexible enough to allow for idiosyncrasies from various tools (e.g. see any GenBank output from anywhere). I tend to veer in the direction of flexibility within reason; having a test suite helps quite a bit.<br>
<br></blockquote><div><br></div><div>In general I agree that having some wiggle room when reading is good. However it is also good to have the option of stricter interpretations of the data format specification, to catch errors like this and give users the option of informing the source of such data that their output needs to be adjusted to match the format specification. This makes it easier to ensure that tools which write these formats use stricter interpretations than those that read them, and outcome which makes everyone happier.</div><div><br></div><div>All the best,</div><div><br></div><div>Hamish</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
chris<br>
<div class="HOEnZb"><div class="h5"><br>
_______________________________________________<br>
Bioperl-l mailing list<br>
<a href="mailto:Bioperl-l@mailman.open-bio.org">Bioperl-l@mailman.open-bio.org</a><br>
<a href="http://mailman.open-bio.org/mailman/listinfo/bioperl-l" target="_blank">http://mailman.open-bio.org/mailman/listinfo/bioperl-l</a></div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">----<br>"Saying the internet has changed dramatically over the last five years is cliché – the internet is always changing dramatically" - Craig Labovitz, Arbor Networks.<br></div>
</div></div>