[Bioperl-l] SeqFeature->_expand_region

[Heikki Lehvaslaiho]

Hilmar, 

If you get OK from Chris, yes please, migrate the changes into the 
branch.

	-Heikki

On Thu, 2003-07-03 at 09:08, Hilmar Lapp wrote:
> On Wednesday, July 2, 2003, at 10:18  PM, Hilmar Lapp wrote:
> 
> >
> > On Wednesday, July 2, 2003, at 09:50  PM, Chris Mungall wrote:
> >
> >> are you suggesting we change Location::Atomic to return undefined 
> >> when not
> >> known?
> >>
> >
> > Not when not known but when not set. I.e., simply
> >
> > 	return $self->{'_strand'};
> >
> > instead of
> >
> > 	return $self->{'_strand'} || 0;
> >
> > I'm testing this right now for its knock-on effects. I suspect there 
> > might be some. But my take is that it is almost always wrong to make 
> > up a value where none has been set.
> 
> OK - done. Indeed there was a whole cascade of knock-on effects. I 
> fixed them all. Scary.
> 
> Shall I migrate this to the branch? Heikki what's your call?
> 
> Chris, does your use case work now?
> 
> 	-hilmar
-- 
______ _/      _/_____________________________________________________
      _/      _/                      http://www.ebi.ac.uk/mutations/
     _/  _/  _/  Heikki Lehvaslaiho    heikki_at_ebi ac uk
    _/_/_/_/_/  EMBL Outstation, European Bioinformatics Institute
   _/  _/  _/  Wellcome Trust Genome Campus, Hinxton
  _/  _/  _/  Cambs. CB10 1SD, United Kingdom
     _/      Phone: +44 (0)1223 494 644   FAX: +44 (0)1223 494 468
___ _/_/_/_/_/________________________________________________________