[Biojava-dev] [Bug 2186] New: ABIFparser never releases file resouce when generated with a File

[bugzilla-daemon at portal.open-bio.org]

http://bugzilla.open-bio.org/show_bug.cgi?id=2186

           Summary: ABIFparser never releases file resouce when generated
                    with a File
           Product: BioJava
           Version: 1.4
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: bio
        AssignedTo: biojava-dev at biojava.org
        ReportedBy: keiranmraine at gmail.com


Hi all,

I've detected a resource problem in the use of the following object constructor

org.biojava.bio.program.abi.ABIFParser(File f)

If you generate the parser in this manner the generated RandomAccessFile is
never closed and causes a resource leak.  The way the code is written I cannot
see an obvious place to close this, but there appears to be a simple fix in
that you can use the alternative method:

org.biojava.bio.program.abi.ABIFParser(InputStream in)

and control the closing outside of Biojava.

As I say I'm not sure at which point it's safe to close the stream in
ABIFParser but the File method could be removed??

Keiran


-- 
Configure bugmail: http://bugzilla.open-bio.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.