[Biojava-dev] [Fwd: Re: BioJava Code Submission]

[Schreiber, Mark]

Hi,

At a first glance this looks nice, I was working on something very
similar myself but got delayed so I'm glad someone else has done it. I
would like to add a few comments.

It would be nice if I could provide a URL to these classes. Some
companies use internal QBlast servers. Also for people who exist behind
firewalls that require validation it would be preferable to be able to
pass a URLConnection as an alternative to the URL that way they can do
all the required validation and then pass the pre setup connection.

Finally the nicest way to do it would be to have the ability to use an
InputStream in the constructor so that any messyness required to get to
the 'outside world' can be handeled externaly. As a person who sits
behind a firewall that makes fort knox look like a paper bag I am very
opposed to using URLs as arguments. InputStreams are much nicer. Also
Hard coding URLs is not 'pure' Java.

So in summary I think the classes are great. If they could have
overloaded constructors to optionally take different URL, URLConnection
or InputStreams as arguments that would be great. Also, if you don't
want to add these pre check-in I can add them post check in.

Good work!

- mark


> -----Original Message-----
> From: Matthew Pocock [mailto:matthew_pocock at yahoo.co.uk] 
> Sent: Tuesday, 11 March 2003 8:02 a.m.
> To: biojava-dev at biojava.org
> Subject: [Biojava-dev] [Fwd: Re: BioJava Code Submission]
> 
> 
> Thanks to Tim for this. Anybody got thoughts/sudgestions?
> 
> Matthew
> 
> -- 
> BioJava Consulting LTD - Support and training for BioJava 
> http://www.biojava.co.uk
> 
=======================================================================
Attention: The information contained in this message and/or attachments
from AgResearch Limited is intended only for the persons or entities
to which it is addressed and may contain confidential and/or privileged
material. Any review, retransmission, dissemination or other use of, or
taking of any action in reliance upon, this information by persons or
entities other than the intended recipients is prohibited by AgResearch
Limited. If you have received this message in error, please notify the
sender immediately.
=======================================================================