[Biopython-dev] [Bug 2169] 'close' method is missing for ReseekFile wrapper

bugzilla-daemon at portal.open-bio.org bugzilla-daemon at portal.open-bio.org
Thu Feb 15 21:29:45 UTC 2007


http://bugzilla.open-bio.org/show_bug.cgi?id=2169





------- Comment #1 from mdehoon at ims.u-tokyo.ac.jp  2007-02-15 16:29 EST -------
I would think that no "close" is needed in PDBParser's get_structure method. If
the argument "file" is an open handle, get_structure closes it, which appears
to be an unwanted side-effect. If the argument "file" is a string, then "file =
open(file)" in get_structure opens a file, and Python will close it for you
once the file variable goes out of scope (when the function returns). Thomas,
am I missing something? Do you have any objections against removing the
"close"?

--Michiel.


-- 
Configure bugmail: http://bugzilla.open-bio.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the Biopython-dev mailing list