[Biopython-dev] Notification: incoming/80

[biopython-bugs at bioperl.org]

JitterBug notification

new message incoming/80

Message summary for PR#80
	From: daishi at egcrc.net
	Subject: Bio.File.SGMLHandle tail condition error
	Date: Mon, 5 Aug 2002 20:38:23 -0400
	0 replies 	0 followups

====> ORIGINAL MESSAGE FOLLOWS <====

>From daishi at egcrc.net Mon Aug  5 20:38:23 2002
Received: from localhost (localhost [127.0.0.1])
	by pw600a.bioperl.org (8.12.2/8.12.2) with ESMTP id g760cNJD019971
	for <biopython-bugs at pw600a.bioperl.org>; Mon, 5 Aug 2002 20:38:23 -0400
Date: Mon, 5 Aug 2002 20:38:23 -0400
Message-Id: <200208060038.g760cNJD019971 at pw600a.bioperl.org>
From: daishi at egcrc.net
To: biopython-bugs at bioperl.org
Subject: Bio.File.SGMLHandle tail condition error

Full_Name: daishi
Module: Bio.File.SGMLHandle
Version: CVS 1.13
OS: Linux
Submission from: 63-193-205-1.egcrc.org (63.193.205.1)


Starting at L154 of File.py is the code:

        if self._parser.data:
            str = self._parser.data
        elif is_newline:
            str = '\n'
        return str

There needs to be a final else clause to
catch the circumstance when the file ends
with a tag but no newline. As it is currently,
such a tag will be returned by SGMLStripper
since str would not be redefined.

Since this can only occur at the end of a file,
I believe this can just be changed to:

        if self._parser.data:
            str = self._parser.data
        elif is_newline:
            str = '\n'
        else:
            str = ''
        return str