<html><body class="ApplePlainTextBody" style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Mitch,<br><br>I went ahead and committed that fix (r16695), seems to pass all SeqFeature::Store tests using mem, BDB, mysql. thanks for the patch!<br><br>chris<br><br>On Jan 14, 2010, at 4:10 PM, Mitch Skinner wrote:<br><br><blockquote type="cite">Hi,<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">Some people haven't been getting all of the features in their GFF3 into JBrowse, and a nice test case that James Casbon posted to the list helped me track it down.<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">Here's an example of the behavior I was seeing with BioPerl 1.6.1 (using Devel::REPL):<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">==============<br></blockquote><blockquote type="cite">$ use Bio::DB::SeqFeature::Store<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">$ my $db = Bio::DB::SeqFeature::Store->new(-adaptor=>"memory", -dsn=>"casbon.gff3")<br></blockquote><blockquote type="cite">$Bio_DB_SeqFeature_Store_memory1 = Bio::DB::SeqFeature::Store::memory=HASH(0xa27ceec);<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">$ $db->features(-seq_id=>"CYP2C8")<br></blockquote><blockquote type="cite">$ARRAY1 = [<br></blockquote><blockquote type="cite"> Feature:src(41),<br></blockquote><blockquote type="cite"> region(CYP2C8),<br></blockquote><blockquote type="cite"> Feature:src(37),<br></blockquote><blockquote type="cite"> Feature:src(39),<br></blockquote><blockquote type="cite"> Feature:src(42),<br></blockquote><blockquote type="cite"> Feature:src(40),<br></blockquote><blockquote type="cite"> Feature:src(38)<br></blockquote><blockquote type="cite"> ];<br></blockquote><blockquote type="cite">==============<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">I expected to also see the features with IDs 43 and 44 (the gff3 file is attached).<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">I think there's a problem in the filter_by_location method. If start and end parameters aren't passed to the method, it sets default start and end values that lead it to examine all of the bins in its index. But the end value that it creates is at the beginning of the last bin, and I think it should be at the end of the last bin instead. The attached patch changes it to be at the end of the last bin.<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">Regards,<br></blockquote><blockquote type="cite">Mitch<br></blockquote><blockquote type="cite"><casbon.gff3><bdsfsm-filter_by_location.patch>_______________________________________________<br></blockquote><blockquote type="cite">Bioperl-l mailing list<br></blockquote><blockquote type="cite">Bioperl-l@lists.open-bio.org<br></blockquote><blockquote type="cite">http://lists.open-bio.org/mailman/listinfo/bioperl-l<br></blockquote><br></body></html>