[Bioperl-l] Bio::Root::Root::new()

Heikki Lehvaslaiho heikki@ebi.ac.uk
09 Dec 2002 13:57:45 +0000


Hi Hilmar,

You fixed the Root new method three weeks ago. Now if an odd number of
arguments is passed to the constructor, it does not complain but tries
to set verbose() on. I do not understand why verbose is important?
Wouldn't it make more sense to throw? 

  shift if @_ % 2;  
  =>  
  $self->throw("Uneven number of arguments ". join(", ") @_) if @_ $ 2;

	-Heikki

-- 
______ _/      _/_____________________________________________________
      _/      _/                      http://www.ebi.ac.uk/mutations/
     _/  _/  _/  Heikki Lehvaslaiho          heikki@ebi.ac.uk
    _/_/_/_/_/  EMBL Outstation, European Bioinformatics Institute
   _/  _/  _/  Wellcome Trust Genome Campus, Hinxton
  _/  _/  _/  Cambs. CB10 1SD, United Kingdom
     _/      Phone: +44 (0)1223 494 644   FAX: +44 (0)1223 494 468
___ _/_/_/_/_/________________________________________________________